[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 2/7] xen: xsm: flask: introduce XENMAPSPACE_gmfn_share for memory sharing

Hi Jan,

2018-02-13 23:26 GMT+08:00 Jan Beulich <JBeulich@xxxxxxxx>:
>>>> On 13.02.18 at 16:15, <blackskygg@xxxxxxxxx> wrote:
>> I've updated the comments according to your previous suggestions,
>> do they look good to you?
> The one in the public header is way too verbose. I specifically don't
> see why you would need to spell out XSM privilege requirements
> there. Please make new comments match existing ones in style and
> verbosity if at all possible, while still conveying all necessary /
> relevant information.

I shortened it a little bit, and now it looks like:

#define XENMAPSPACE_gmfn_share   6 /* GMFN from another dom. Unlike
                                      if (c) tries to map pages from (t) into
                                      (d), this doesn't require that (d) itself
                                      has the privilege to map the pages, but
                                      instead requires that (c) has the
                                      privilege to do so, as long as (d) and (t)
                                      are allowed to share memory pages.
                                      This is XENMEM_add_to_physmap_batch only,
                                      and currently ARM only. */


Zhongze Liu

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.