Re: [Xen-devel] [PATCH] x86/srat: fix the end pfn check in valid_numa_range()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.02.18 at 02:44, <haozhong.zhang@xxxxxxxxx> wrote:
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -110,8 +110,8 @@ int valid_numa_range(u64 start, u64 end, nodeid_t node)
>       for (i = 0; i < num_node_memblks; i++) {
>               struct node *nd = &node_memblk_range[i];
>  
> -             if (nd->start <= start && nd->end > end &&
> -                     memblk_nodeid[i] == node )
> +             if (nd->start <= start && nd->end >= end &&
> +                     memblk_nodeid[i] == node)
>                       return 1;
>       }
>  

You also should have fixed the indentation issue on the second
line of the if().

There looks to be a similar issue in nodes_cover_memory(), and I
think it would be rather desirable if a change here dealt with all
such issues rather than just picking one. Anyway - I'll produce a
patch for this second issue.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel