[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 2/4] hvm/svm: Enable Breakpoint events

On 02/08/2018 10:25 AM, Alexandru Isaila wrote:

+           rc = hvm_monitor_debug(regs->rip,
+                                  HVM_MONITOR_SOFTWARE_BREAKPOINT,
+                                  X86_EVENTTYPE_SW_EXCEPTION,
+                                  inst_len);
+           if ( rc < 0 )
+               goto unexpected_exit_type;
+           if ( !rc )
+               svm_propagate_intr(v, inst_len);

There is a comment in vmx_vmexit_handler() where this call is made a couple of times that explains hvm_moonitor_debug()'s return values.

Can you move that comment to hvm_monitor_debug() definition so people can look there to understand how to deal with return values instead of searching for call sites?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.