Re: [Xen-devel] [PATCH v2 15/15] xen/arm: psci: Prefix with static any functions not exported

[Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>]

On 08.02.18 21:22, Julien Grall wrote:
> A bunch of PSCI functions are not prefixed with static despite no one is
> using them outside the file and the prototype is not available in
> psci.h.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

> ---
>
>      Changes in v2:
>          - Patch added
> ---
>   xen/arch/arm/psci.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
> index 7a8cf54e6d..5d94a9a9ae 100644
> --- a/xen/arch/arm/psci.c
> +++ b/xen/arch/arm/psci.c
> @@ -66,7 +66,7 @@ static int __init psci_features(uint32_t psci_func_id)
>       return call_smc(PSCI_1_0_FN32_PSCI_FEATURES, psci_func_id, 0, 0);
>   }
>   
> -int __init psci_is_smc_method(const struct dt_device_node *psci)
> +static int __init psci_is_smc_method(const struct dt_device_node *psci)
>   {
>       int ret;
>       const char *prop_str;
> @@ -109,7 +109,7 @@ static void __init psci_init_smccc(void)
>              SMCCC_VERSION_MAJOR(smccc_ver), SMCCC_VERSION_MINOR(smccc_ver));
>   }
>   
> -int __init psci_init_0_1(void)
> +static int __init psci_init_0_1(void)
>   {
>       int ret;
>       const struct dt_device_node *psci;
> @@ -139,7 +139,7 @@ int __init psci_init_0_1(void)
>       return 0;
>   }
>   
> -int __init psci_init_0_2(void)
> +static int __init psci_init_0_2(void)
>   {
>       static const struct dt_device_match psci_ids[] __initconst =
>       {
--
Volodymyr Babchuk

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel