Re: [Xen-devel] [PATCH RFC v2 10/12] x86: allocate per-vcpu stacks for interrupt entries

[Juergen Gross <jgross@xxxxxxxx>]

On 30/01/18 16:40, Jan Beulich wrote:
>>>> On 22.01.18 at 13:32, <jgross@xxxxxxxx> wrote:
>> @@ -37,10 +52,24 @@ struct vcpu;
>>  
>>  struct cpu_info {
>>      struct cpu_user_regs guest_cpu_user_regs;
>> -    unsigned int processor_id;
>> -    struct vcpu *current_vcpu;
>> -    unsigned long per_cpu_offset;
>> -    unsigned long cr4;
>> +    union {
>> +        /* per physical cpu mapping */
>> +        struct {
>> +            struct vcpu *current_vcpu;
>> +            unsigned long per_cpu_offset;
>> +            unsigned long cr4;
>> +        };
>> +        /* per vcpu mapping (xpti) */
>> +        struct {
>> +            unsigned long pad1;
>> +            unsigned long pad2;
>> +            unsigned long stack_bottom_cpu;
>> +        };
> 
> In order to avoid accidental use in the wrong context as much as
> possible, I think you want to name both structures.

I'd like to leave it as is in order to make a possible backport much
more easier.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel