[Xen-devel] libx[lc]: Improve error reporting for invalid kernel images

[Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>]

Hi,

this series cleans up the error reporting in case a invalid kernel image
is supplied. For example if the user tries to boot a pre 4.11 Linux in
PVH mode.

Commit 96edb111dd ("libxc: panic when trying to create a PVH guest
without kernel support") already improved the situation:

  xc: error: panic: xc_dom_elfloader.c:66: xc_dom_guest_type: image not capable 
of booting inside a HVM container: Invalid kernel
  xc: error: panic: xc_dom_core.c:734: xc_dom_set_arch_hooks: not found (type 
xen-3.0-unknown): Invalid kernel
  xc: error: panic: xc_dom_core.c:936: xc_dom_mem_init: arch hooks not set: 
Internal error
  libxl: error: libxl_dom.c:729:libxl__build_dom: xc_dom_mem_init failed: No 
such file or directory
  libxl: error: libxl_create.c:1246:domcreate_rebuild_done: Domain 3:cannot 
(re-)build domain: -3

But you still see that the domain build don't fails immediately in
xc_dom_parse_elf_kernel() but only later in xc_dom_set_arch_hooks().
After fixing this there was still an unrelated errno string logged.

With this series the error reporting is cleaned up:

  xc: error: panic: xc_dom_elfloader.c:66: xc_dom_guest_type: image not capable 
of booting inside a HVM container: Invalid kernel
  libxl: error: libxl_dom.c:718:libxl__build_dom: xc_dom_parse_image failed
  libxl: error: libxl_create.c:1246:domcreate_rebuild_done: Domain 4:cannot 
(re-)build domain: -3

For some previous discussion see [1].

Simon

[1]: https://lists.xenproject.org/archives/html/xen-devel/2018-01/msg01675.html


Simon Gaiser (3):
      libxc: Cleanup xc_dom_parse_elf_kernel()'s return value
      libxl: Improve logging in libxl__build_dom()
      libxc: xc_dom_parse_elf_kernel: Return error for invalid kernel images

 tools/libxc/xc_dom_elfloader.c | 24 +++++++++++++-----------
 tools/libxl/libxl_dom.c        |  2 +-
 2 files changed, 14 insertions(+), 12 deletions(-)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel