[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/4] firmware/shim: better filtering of dependency files during Xen tree setup

On Wed, Feb 07, 2018 at 08:07:40AM -0700, Jan Beulich wrote:
> I have no idea what *.d1 is supposed to refer to - we only have .*.d
> and .*.d2 files (note also the leading dot).
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> --- a/tools/firmware/xen-dir/Makefile
> +++ b/tools/firmware/xen-dir/Makefile
> @@ -26,7 +26,7 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES)
>       $(foreach d, $(LINK_DIRS), \
>               (cd $(XEN_ROOT); \
>                find $(d) ! -type l -type f \
> -              $(addprefix ! -path , '*.[oda1]' '*.d[12]')) \
> +              $(addprefix ! -path , '*.[oa1]' '.*.d' '.*.d2')) \

Don't you want -name here instead of -path?

AFAICT using '.*.d' is not going to work with path, because that's the
full path, not the name of the file. This used to work before because
the patterns started with '*'.

Also I cannot find any .a or .1 files, but maybe that's just because
of my build system (I don't build EFI).

Thanks, Roger.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.