Re: [Xen-devel] [PATCH v4 2/7] xen: xsm: flask: introduce XENMAPSPACE_gmfn_share for memory sharing

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 01/30/2018 05:50 PM, Zhongze Liu wrote:
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 3c328e2df5..8e385d62a8 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1251,6 +1251,7 @@ int xenmem_add_to_physmap_one(
>   
>           break;
>       case XENMAPSPACE_gmfn_foreign:
> +    case XENMAPSPACE_gmfn_share:
>       {
>           struct domain *od;
>           p2m_type_t p2mt;
> @@ -1265,7 +1266,12 @@ int xenmem_add_to_physmap_one(
>               return -EINVAL;
>           }
>   
> -        rc = xsm_map_gmfn_foreign(XSM_TARGET, d, od);
> +        if ( space == XENMAPSPACE_gmfn_foreign ) {
> +            rc = xsm_map_gmfn_foreign(XSM_TARGET, d, od);
> +        } else {
> +            rc = xsm_map_gmfn_share(XSM_TARGET, d, od);
> +        }
Coding style:

if ( .... )
{
}
else
{
}

But in that case, there braces are not necessary. So you could do
if ( ... )
  ...
else
  ...

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel