Re: [Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.02.18 at 18:15, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 02/03/2018 12:10 PM, Andrew Cooper wrote:
>> On 03/02/18 17:03, Boris Ostrovsky wrote:
>>>
>>>
>>> On 01/31/2018 03:35 PM, Brian Woods wrote:
>>>> Corrects some EFER.SVME checks in intercepts.  See AMD APM vol2 section
>>>> 15.4 for more details.  VMMCALL isn't checked due to guests needing it
>>>> to boot.
>>>>
>>>
>>> Don't you need SVME be on for VMMCALL?
>> 
>> In real hardware, yes.
>> 
>> However, it's quite unreasonable to require the guest to have activated
>> its idea of EFER.SVME before it can make hypercalls :)
> 
> 
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

I've applied this patch together with patch 1 on the assumption
that it doesn't depend on patch 2 (which I've commented on).
Let me know if this was a mistake and there is a dependency (in
which case I'll revert).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel