Re: [Xen-devel] [PATCH v10 08/11] x86/boot: Calculate the most appropriate BTI mitigation to use

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.01.18 at 14:12, <andrew.cooper3@xxxxxxxxxx> wrote:
>  void __init init_speculation_mitigations(void)
>  {
>      enum ind_thunk thunk = THUNK_DEFAULT;
> +    bool ibrs = false;
>  
>      /*
>       * Has the user specified any custom BTI mitigations?  If so, follow 
> their
>       * instructions exactly and disable all heuristics.
>       */
> -    if ( opt_thunk != THUNK_DEFAULT )
> +    if ( opt_thunk != THUNK_DEFAULT || opt_ibrs != -1 )
>      {
>          thunk = opt_thunk;
> +        ibrs  = !!opt_ibrs;
>      }

The comment above has become stale with later additions. Question
is what the intentions are, i.e. whether it is the comment or the code
that should be changed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel