[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 8/8] ARM: make nr_irqs a constant

Hi Andre,

On 24/01/18 18:10, Andre Przywara wrote:
On ARM the maximum number of IRQs is a constant, but we share it being
a variable to match x86. Since we are not supposed to alter it, let's
mark it as "const" to avoid accidental change.

Suggested-by: Julien Grall <julien.grall@xxxxxxxxxx>
Signed-off-by: Andre Przywara <andre.przywara@xxxxxxxxxx>

Acked-by: Julien Grall <julien.grall@xxxxxxx>


  xen/arch/arm/irq.c        | 2 +-
  xen/include/asm-arm/irq.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
index 62103a20e3..d229cb6871 100644
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -27,7 +27,7 @@
  #include <asm/gic.h>
  #include <asm/vgic.h>
-unsigned int __read_mostly nr_irqs = NR_IRQS;
+const unsigned int __read_mostly nr_irqs = NR_IRQS;
static unsigned int local_irqs_type[NR_LOCAL_IRQS];
  static DEFINE_SPINLOCK(local_irqs_type_lock);
diff --git a/xen/include/asm-arm/irq.h b/xen/include/asm-arm/irq.h
index 0d110ecb08..9d55e9b122 100644
--- a/xen/include/asm-arm/irq.h
+++ b/xen/include/asm-arm/irq.h
@@ -34,7 +34,7 @@ struct arch_irq_desc {
  /* This is a spurious interrupt ID which never makes it into the GIC code. */
  #define INVALID_IRQ     1023
-extern unsigned int nr_irqs;
+extern const unsigned int nr_irqs;
  #define nr_static_irqs NR_IRQS
  #define arch_hwdom_irqs(domid) NR_IRQS

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.