Re: [Xen-devel] [PATCH] x86/asm: Drop __GET_CURRENT()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.01.18 at 19:12, <andrew.cooper3@xxxxxxxxxx> wrote:
> __GET_CURRENT() is very dangerous to use, as is easy to confuse with

I wouldn't say "very", but for the change as a whole - well, yes, why
not.

> GET_CURRENT(), but strictly depends on the regster parameter already having
> the STACK_END value in it.  Also, there is no reason to special case accesses
> of current_vcpu differently to other cpuinfo fields.
> 
> Expand __GET_CURRENT() in its current users, and remove the macro.
> 
> Take the opportunity to replace the GET_CURRENT() in the cstar path which
> doesn't need to recalculate STACK_END.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel