[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] firmware/shim: fix build process to use POSIX find options



On Fri, Jan 26, 2018 at 01:54:30PM -0600, Michael Glasgow wrote:
> This recent patch can be simplified a bit.  (The patch below is
> untested, just a suggestion.)
> 

Thanks, this LGTM, but it needs your Signed-off-by tag in order to be
applied.

Also remember to Cc the maintainers when resending, I've done this for
you now.

> diff -ur a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
> --- a/tools/firmware/xen-dir/Makefile 2018-01-26 11:40:00.711389605 -0600
> +++ b/tools/firmware/xen-dir/Makefile 2018-01-26 11:51:41.279825142 -0600
> @@ -20,9 +20,8 @@
>       rm -f linkfarm.stamp.tmp
>       $(foreach d, $(LINK_DIRS), \
>                (mkdir -p $(D)/$(d); \
> -               cd $(D)/$(d); \
> -               find $(XEN_ROOT)/$(d)/ -type d -exec sh -c \
> -                   "echo {} | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir 
> -p" \;);)
> +               cd $(D)/$(d) && \
> +               (cd $(XEN_ROOT)/$(d) && find . -type d) | xargs mkdir -p \;);)
>       $(foreach d, $(LINK_DIRS), \
>               (cd $(XEN_ROOT); \
>                find $(d) ! -type l -type f \
> 
> 
> -- 
> Michael Glasgow <glasgow@xxxxxxxx>
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.