Re: [Xen-devel] [PATCH 3/3] xen/arm: vpsci: Move PSCI function dispatching from vsmc.c to vpsci.c

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi,

On 26/01/18 18:09, Volodymyr Babchuk wrote:
> On 24.01.18 20:34, Julien Grall wrote:
> > -    case PSCI_0_2_FN32(AFFINITY_INFO):
> > -    case PSCI_0_2_FN64(AFFINITY_INFO):
> > +    switch ( fid )
> >       {
> > -        register_t taff = PSCI_ARG(regs, 1);
> > -        uint32_t laff = PSCI_ARG32(regs, 2);
> > -
> > -        perfc_incr(vpsci_cpu_affinity_info);
> > -        PSCI_SET_RESULT(regs, do_psci_0_2_affinity_info(taff, laff));
> > -        return true;
> > -    }
> > -
> >       case ARM_SMCCC_FUNC_CALL_COUNT(STANDARD):
> >           return fill_function_call_count(regs, 
> > SSSC_SMCCC_FUNCTION_COUNT);
> Now definition SSSC_SMCCC_FUNCTION_COUNT depends on code in vscpi.c.
> Maybe it is time to introduce function get_psci_0_2_fn_count() and use 
> it there, what do you think?
Definitely not a function. It is a static number. But I can think of 
separate the call count.
Cheers,

> > diff --git a/xen/include/asm-arm/psci.h b/xen/include/asm-arm/psci.h
> > index f7e2139031..3075c998f3 100644
> > --- a/xen/include/asm-arm/psci.h
> > +++ b/xen/include/asm-arm/psci.h
> > @@ -22,24 +22,9 @@ int call_psci_cpu_on(int cpu);
> >   void call_psci_system_off(void);
> >   void call_psci_system_reset(void);
> > -/* functions to handle guest PSCI requests */
> > -int32_t do_psci_cpu_on(uint32_t vcpuid, register_t entry_point);
> > -int32_t do_psci_cpu_off(uint32_t power_state);
> > -int32_t do_psci_cpu_suspend(uint32_t power_state, register_t 
> > entry_point);
> > -int32_t do_psci_migrate(uint32_t vcpuid);
> > -
> > -/* PSCI 0.2 functions to handle guest PSCI requests */
> > -uint32_t do_psci_0_2_version(void);
> > -register_t do_psci_0_2_cpu_suspend(uint32_t power_state, register_t 
> > entry_point,
> > -                            register_t context_id);
> > -int32_t do_psci_0_2_cpu_off(void);
> > -int32_t do_psci_0_2_cpu_on(register_t target_cpu, register_t 
> > entry_point,
> > -                       register_t context_id);
> > -int32_t do_psci_0_2_affinity_info(register_t target_affinity,
> > -                              uint32_t lowest_affinity_level);
> > -uint32_t do_psci_0_2_migrate_info_type(void);
> > -void do_psci_0_2_system_off(void);
> > -void do_psci_0_2_system_reset(void);
> > +/* Functions handle PSCI calls from the guests */
> > +bool do_psci_0_1_call(struct cpu_user_regs *regs, uint32_t fid);
> > +bool do_psci_0_2_call(struct cpu_user_regs *regs, uint32_t fid);
> >   /* PSCI v0.2 interface */
> >   #define PSCI_0_2_FN32(name) 
> > ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL,             \
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel