Re: [Xen-devel] [PATCH 3/7] xen/arm32: entry: Add missing trap_reset entry

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Stefano,

On 24/01/18 23:14, Stefano Stabellini wrote:
> On Fri, 19 Jan 2018, Julien Grall wrote:
> > At the moment, the reset vector is defined as .word 0 (e.g andeq r0, r0,
> > r0).
> >
> > This is rather unintuitive and will result to execute the trap
> > undefined. Instead introduce trap helpers for reset and will generate an
> > error message in the unlikely case that reset will be called.
> >
> > This is part of XSA-254.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > ---
> >   xen/arch/arm/arm32/entry.S | 1 +
> >   xen/arch/arm/arm32/traps.c | 5 +++++
> >   2 files changed, 6 insertions(+)
> >
> > diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S
> > index c6490d2847..c2fad5fe9b 100644
> > --- a/xen/arch/arm/arm32/entry.S
> > +++ b/xen/arch/arm/arm32/entry.S
> > @@ -146,6 +146,7 @@ GLOBAL(hyp_traps_vector)
> >           b trap_irq                      /* 0x18 - IRQ */
> >           b trap_fiq                      /* 0x1c - FIQ */
> >   
> > +DEFINE_TRAP_ENTRY(reset)
> This is OK, but shouldn't we also change the entry under
> GLOBAL(hyp_traps_vector), from ".word 0" to "b trap_reset" ?
That was my plan but forgot to do it :/ I will update the patch and 
resend it.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel