Re: [Xen-devel] [PATCH] x86/shutdown: Use ACPI reboot method for Dell PowerEdge R740

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 01/22/2018 12:29 PM, Jan Beulich wrote:
> > > > On 19.01.18 at 17:57, <ross.lagerwall@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/shutdown.c
> > +++ b/xen/arch/x86/shutdown.c
> > @@ -511,6 +511,15 @@ static struct dmi_system_id __initdata reboot_dmi_table[] 
> > = {
> >               DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6520"),
> >           },
> >       },
> > +    {    /* Handle problems with rebooting on Dell PowerEdge R740. */
> > +        .callback = override_reboot,
> > +        .driver_data = (void *)(long)BOOT_ACPI,
> > +        .ident = "Dell PowerEdge R740",
> > +        .matches = {
> > +            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +            DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740"),
> > +        },
> > +    },
> Judging from the description you don't really want or need to
> override the reboot method if not running under EFI, or if there
> was an override on the command line already. override_reboot(),
> however, overrides everything and under all circumstances. I
> therefore think you may want to introduce a new callback
> function.
Agreed, it should only apply when running under EFI. Note that the 
command-line takes priority over override_reboot() -- see the note at 
the start of reboot_init().
> As an aside - how come the page at address zero is actually
> mapped at the time of the reboot attempt?
No idea...

--
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel