[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5] x86: relocate pvh_info

On 23/01/18 15:13, Wei Liu wrote:
> @@ -226,14 +259,27 @@ static multiboot_info_t *mbi2_reloc(u32 mbi_in)
>      return mbi_out;
>  }
> -multiboot_info_t __stdcall *reloc(u32 mb_magic, u32 mbi_in, u32 trampoline)
> +void __stdcall *reloc(u32 magic, u32 in, u32 trampoline)

As an final observation, void * __stdcall reloc() so the __stdcall isn't
in the middle of the return type (Can be fixed on commit).

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.