[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4] x86: relocate pvh_info

>>> On 22.01.18 at 19:31, <wei.liu2@xxxxxxxxxx> wrote:
> On Mon, Jan 22, 2018 at 06:19:43PM +0000, Andrew Cooper wrote:
>> On 22/01/18 18:17, Wei Liu wrote:
>> > So you want reloc.o to contain pvh_info_reloc unconditionally?
>> >
>> > Fundamentally I don't think I care enough about all the bikeshedding so
>> > if Jan and you agree on this I will just make the change.
>> It wont.  The function will be dropped due to DCE, but we'll spot build
>> breakages far more easily.  (The important bit is that the function call
>> is guarded by the IS_ENABLED())
> reloc.o will still have that function in non-PVH build on my machine.
> And that's with the following diff applied.

Well, DCE doesn't make any promises towards what it is able to
eliminate, which is why generally I prefer to help the compiler in
cases like the one here.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.