[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] xen/shim: stash RSDP address for ACPI driver

>>> On 22.01.18 at 16:34, <roger.pau@xxxxxxxxxx> wrote:
> On Mon, Jan 22, 2018 at 03:02:52PM +0000, Wei Liu wrote:
>> --- a/xen/drivers/acpi/osl.c
>> +++ b/xen/drivers/acpi/osl.c
>> @@ -62,8 +62,13 @@ void __init acpi_os_vprintf(const char *fmt, va_list args)
>>      printk("%s", buffer);
>>  }
>> +acpi_physical_address rsdp_hint;
> Since this is only used by acpi_os_get_root_pointer it should be
> __initdata. I also prefer to place global variables at the top of the
> file after the includes, but that's just a matter of taste I guess.

I think keeping such limited use variable declarations /
definitions close to their use site is quite okay, if not


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.