[Xen-devel] [libvirt test] 118265: trouble: broken/pass

[osstest service owner <osstest-admin@xxxxxxxxxxxxxx>]

flight 118265 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/118265/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-libvirt-vhd    <job status>                 broken
 test-amd64-i386-libvirt-xsm     <job status>                 broken
 test-amd64-i386-libvirt-xsm   4 host-install(4)        broken REGR. vs. 118237
 test-amd64-amd64-libvirt-vhd  4 host-install(4)        broken REGR. vs. 118237

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-xsm 14 saverestore-support-check    fail  like 118237
 test-armhf-armhf-libvirt     14 saverestore-support-check    fail  like 118237
 test-armhf-armhf-libvirt-raw 13 saverestore-support-check    fail  like 118237
 test-amd64-amd64-libvirt     13 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      13 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 13 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 14 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     13 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     14 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-qcow2 12 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 13 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check 
fail never pass
 test-armhf-armhf-libvirt-xsm 13 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     13 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              7ce8ff0f88b7f5f09f3bd05b51086689ccf6227a
baseline version:
 libvirt              71d56a397925a1bd55d3aee30afdbdcd1a14f9a8

Last test of basis   118237  2018-01-19 19:48:17 Z    2 days
Testing same since   118265  2018-01-22 04:20:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Laine Stump <laine@xxxxxxxxx>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-armhf-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-armhf-armhf-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  broken  
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-libvirt-vhd                                 broken  


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-libvirt-vhd broken
broken-job test-amd64-i386-libvirt-xsm broken
broken-step test-amd64-i386-libvirt-xsm host-install(4)
broken-step test-amd64-amd64-libvirt-vhd host-install(4)

Not pushing.

------------------------------------------------------------
commit 7ce8ff0f88b7f5f09f3bd05b51086689ccf6227a
Author: Laine Stump <laine@xxxxxxxxx>
Date:   Mon Dec 18 10:19:40 2017 -0500

    qemu: move qemuDomainDefValidateVideo into qemuDomainDeviceDefValidateVideo
    
    qemuDomainDefValidateVideo() (called from qemuDomainDefValidate()) is
    just a loop performing various checks on each video device. Rather
    than maintaining this separate function, just fold the validations
    into qemuDomainDeviceDefValidateVideo(), which is called once for each
    video device.

commit 18c24bc686af7e59387ced8c07a013eef4e289e6
Author: Laine Stump <laine@xxxxxxxxx>
Date:   Fri Dec 15 11:42:35 2017 -0500

    qemu: assign correct type of PCI address for vhost-scsi when using pcie-root
    
    Commit 10c73bf1 fixed a bug that I had introduced back in commit
    70249927 - if a vhost-scsi device had no manually assigned PCI
    address, one wouldn't be assigned automatically. There was a slight
    problem with the logic of the fix though - in the case of domains with
    pcie-root (e.g. those with a q35 machinetype),
    qemuDomainDeviceCalculatePCIConnectFlags() will attempt to determine
    if the host-side PCI device is Express or legacy by examining sysfs
    based on the host-side PCI address stored in
    hostdev->source.subsys.u.pci.addr, but that part of the union is only
    valid for PCI hostdevs, *not* for SCSI hostdevs. So we end up trying
    to read sysfs for some probably-non-existent device, which fails, and
    the function virPCIDeviceIsPCIExpress() returns failure (-1).
    
    By coincidence, the return value is being examined as a boolean, and
    since -1 is true, we still end up assigning the vhost-scsi device to
    an Express slot, but that is just by chance (and could fail in the
    case that the gibberish in the "hostside PCI address" was the address
    of a real device that happened to be legacy PCI).
    
    Since (according to Paolo Bonzini) vhost-scsi devices appear just like
    virtio-scsi devices in the guest, they should follow the same rules as
    virtio devices when deciding whether they should be placed in an
    Express or a legacy slot. That's accomplished in this patch by
    returning early with virtioFlags, rather than erroneously using
    hostdev->source.subsys.u.pci.addr. It also adds a test case for PCIe
    to assure it doesn't get broken in the future.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel