Re: [Xen-devel] [PATCH v2 4/7] x86/shim: use credit scheduler

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jan 19, 2018 at 03:34:55PM +0000, Wei Liu wrote:
> Remove sched=null from shim cmdline and doc
> 
> We use the default scheduler (credit1 as of writing). The NULL
> scheduler still has bugs to fix.
> 
> Update shim.config.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
>  docs/man/xl.cfg.pod.5.in           | 2 +-
>  tools/firmware/xen-dir/shim.config | 7 +++----
>  tools/libxl/libxl_internal.h       | 2 +-
>  3 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
> index 30fe4b8531..a699367779 100644
> --- a/docs/man/xl.cfg.pod.5.in
> +++ b/docs/man/xl.cfg.pod.5.in
> @@ -531,7 +531,7 @@ Ignored if pvhsim is false.
>  =item B<pvshim_cmdline="STRING">
>  
>  Command line for the shim.
> -Default is "pv-shim console=xen,pv sched=null".
> +Default is "pv-shim console=xen,pv".
>  Ignored if pvhsim is false.

The above chunk would be nice to backport to the 4.10 branch for
correctness.

> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 0f89364466..7ff9a67e50 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -119,7 +119,7 @@
>  #define DOMID_XS_PATH "domid"
>  #define INVALID_DOMID ~0
>  #define PVSHIM_BASENAME "xen-shim"
> -#define PVSHIM_CMDLINE "pv-shim console=xen,pv sched=null"
> +#define PVSHIM_CMDLINE "pv-shim console=xen,pv"

Together with this one. sched=null has no effect on the 4.10 branch
because the shim by default is compiled without null scheduler
support.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel