Re: [Xen-devel] [PATCH 6/6] drop "domain_" prefix from struct domain's dirty CPU mask

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/01/18 16:07, Jan Beulich wrote:
> It being a field of struct domain is sufficient to recognize its
> purpose.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although...
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -3327,7 +3327,7 @@ long do_mmuext_op(
>              if ( unlikely(currd != pg_owner) )
>                  rc = -EPERM;
>              else if ( __addr_ok(op.arg1.linear_addr) )
> -                flush_tlb_one_mask(currd->domain_dirty_cpumask,
> +                flush_tlb_one_mask(currd->dirty_cpumask,
>                                     op.arg1.linear_addr);
>              break;
>  
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -3639,7 +3639,7 @@ static void sh_unshadow_for_p2m_change(s
>                      if ( sh_remove_all_mappings(d, omfn,
>                                                  _gfn(gfn + (i << 
> PAGE_SHIFT))) )
>                          cpumask_or(&flushmask, &flushmask,
> -                                   d->domain_dirty_cpumask);
> +                                   d->dirty_cpumask);
>                  }
>                  omfn = _mfn(mfn_x(omfn) + 1);
>              }
>

Can either of these hunks be re-flowed onto a single line?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel