Re: [Xen-devel] [PATCH 5/9] x86: relocate pvh_info

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.01.18 at 19:16, <wei.liu2@xxxxxxxxxx> wrote:
> Modify early boot code to relocate pvh info as well, so that we can be
> sure __va in __start_xen works.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one cosmetic request:

> @@ -29,6 +29,10 @@ asm (
>  #include "../../../include/xen/multiboot.h"
>  #include "../../../include/xen/multiboot2.h"
>  
> +#ifdef CONFIG_PVH_GUEST
> +#include <public/arch-x86/hvm/start_info.h>
> +#endif

Would you mind moving the #include ...

> @@ -71,6 +75,38 @@ static u32 copy_string(u32 src)
>      return copy_mem(src, p - src + 1);
>  }
>  
> +#ifdef CONFIG_PVH_GUEST
> +static struct hvm_start_info *pvh_info_reloc(u32 in)

... above this line, to avoid the duplicate #ifdef?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel