Re: [Xen-devel] [PATCH] xen: append EXTRA_CFLAGS to CFLAGS for expert builds

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.01.18 at 18:04, <cardoe@xxxxxxxxxx> wrote:
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -75,6 +75,8 @@ ALL_OBJS := $(ALL_OBJS-y)
>  CFLAGS-y += -MMD -MF $(@D)/.$(@F).d
>  
>  CFLAGS += $(CFLAGS-y)
> +# allow extra CFLAGS externally via EXTRA_CFLAGS
> +CFLAGS += $(EXTRA_CFLAGS)

This is too unspecific a name for my taste: Upstream qemu has uses
of such a symbol too, for example (I didn't go check whether those
uses would collide with yours).

You will also want to document this in ./INSTALL, I think. Along with
what's already there, how about naming the new one
EXTRA_CFLAGS_XEN or EXTRA_CFLAGS_XEN_CORE? Considering
the separate shim build, we may then also want
EXTRA_CFLAGS_XEN_SHIM.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel