[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC 11/11] Add to_pci_dev macro

Hi Manish,

Again please use scripts/get_maintainers.pl.

On 02/01/18 09:28, manish.jaggi@xxxxxxxxxx wrote:
From: Manish Jaggi <manish.jaggi@xxxxxxxxxx>

This patch adds to_pci_dev macro

Why? Who is going to use it? If it is a patch in your series, then likely this patch should be before you use it.

Any in case, a commit message a bit more develop will be help.

Signed-off-by: Manish Jaggi <manish.jaggi@xxxxxxxxxx>
  xen/include/xen/pci.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 43f21251a5..4c7ff4dd10 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -92,8 +92,11 @@ struct pci_dev {
      } fault;
      u64 vf_rlen[6];
+    struct device dev;

That's common code. Please look at adding this in arch_pci_dev. But I would need a bit more context why you need that.

+#define to_pci_dev(p) container_of(p, struct pci_dev, dev)
+#define pci_domain_nr(dev) dev->seg
  #define for_each_pdev(domain, pdev) \
      list_for_each_entry(pdev, &(domain->arch.pdev_list), domain_list)


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.