[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 2/4] x86emul: Support vpclmulqdq

>>> On 03.01.18 at 09:26, <yang.zhong@xxxxxxxxx> wrote:
> The previous vpclmulqdq only support AVX128.
> Icelake added AVX256 support.

And 512-bit support as well; you only don't add support for the EVEX
encoding forms in your patch.

The patch itself looks fine, but please clarify its testing status.

> @@ -6168,6 +6169,7 @@ x86_emulate(
>      simd_0f_imm8_avx:
>                  host_and_vcpu_must_have(avx);
>              }
> +    simd_0f_imm8_ymm:
>              get_fpu(X86EMUL_FPU_ymm, &fic);
>          }
>          else if ( vex.pfx )

One remark as I see this: Personally I don't see any of this series go
in ahead of my larger emulator series (or at least large parts of it),
considering that it's been pending for much longer. I'm sorry for this
meaning that you also won't be able to report this task as completed
any time soon. Other maintainers may have a different opinion here,


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.