Re: [Xen-devel] [RFC v4 8/8] drivers/passthrough/arm: Refactor code for arm smmu drivers

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 01/03/2018 05:34 AM, Manish Jaggi wrote:
> Hi Sameer,
Hi Manish,

> > +    unsigned int            type;
> > +
> > +    /* Dummy compatibility defines */
> > +    unsigned long pgsize_bitmap;
> > +    struct iommu_domain_geometry geometry;
> > +
> > +    atomic_t ref;
> > +    /* Used to link iommu_domain contexts for a same domain.
> > +     * There is at least one per-SMMU to used by the domain.
> > +     */
> > +    struct list_head        list;
> > +};
> > +
> > +/* Xen: Describes information required for a Xen domain */
> > +struct arm_smmu_xen_domain {
> > +    spinlock_t          lock;
> > +    /* List of iommu domains associated to this domain */
> > +    struct list_head        contexts;
> Could we use a more verbose name, How about 
> %s/contexts/iommu_domain_contexts/g ?
How about a much more verbose name...? This name is 21 letters and 
that's only for the field. Just imagine with the variable name before 
and a couple of indentation.
This is where comment are helpful, a developer can easily look for the 
structure/field to see a description of the field. So let's not make the 
code more horrible because you would have to split the line.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel