Re: [Xen-devel] [PATCH v3 1/2] public/hvm/params.h: fix comment for timer_mode default

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Jan 15, 2018 at 09:24:51PM -0600, Doug Goldstein wrote:
> In libxl__domain_build_info_setdefault() in
> tools/libxl/libxl_create.c the default for timer_mode for HVM
> and PVH is LIBXL_TIMER_MODE_NO_DELAY_FOR_MISSED_TICKS so adjust the
> comments in the header to reflect this.

IMHO this is not correct. The default in the hypervisor when creating
a guest is HVMPTM_delay_for_missed_ticks, so the header is correct.

The default set by libxl is different, but that's something specific
to libxl, and should only be documented in xl.cfg.

This is not very convenient, but sadly in this case the default in the
hypervisor differs from the default set by libxl, which is confusing.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel