Re: [Xen-devel] [PATCH v4 02/39] arm/p2m: Add first altp2m HVMOP stubs

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 10/01/18 17:16, Sergej Proskurin wrote:
> Hi Julien,
Hi,

> On 10/09/2017 06:43 PM, Julien Grall wrote:
> > Hi Sergej,
> >
> > On 30/08/17 19:32, Sergej Proskurin wrote:
> > > This commit copies and extends the altp2m-related code from x86 to ARM.
> > > Functions that are no yet supported notify the caller or print a BUG
> > > message stating their absence.
> > I am still concerned on the locking differing between x86 and Arm
> > (likely the former is wrong) and for maintain POV in the future.
> >
> > Last year you said you were working on getting do_altp2m_op common
> > between x86 and Arm. What's the status?
> I remember us having the discussion about pulling out common code of
> both architectures. I still believe that this is necessary. Yet, as I
> told you the last time, I really would like to first get the
> implementation for ARM into mainline before blowing up this patch series
> even more.
That's a no-go from my side from 2 reasons:
	1) You add burden in review. I have to make sure that every new code 
you add and make sure you don't get the locking wrong. Common code makes 
easier for that
	2) Most of features added to Arm that already coming from x86 are 
usually consolidated.
So to make clear, the current state:

NAcked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel