Re: [Xen-devel] [PATCH RFC v1 17/74] ---- x86/Kconfig: Options for Xen and PVH support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.01.18 at 14:05, <wei.liu2@xxxxxxxxxx> wrote:

Please drop the stray ---- from the subject.

> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

No description (rationale) at all? But perhaps that's to be attributed
to the RFC nature of the series.

> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -117,6 +117,23 @@ config TBOOT
>         Technology (TXT)
>  
>         If unsure, say Y.
> +
> +config XEN_GUEST
> +     def_bool n
> +     prompt "Xen Guest"
> +     ---help---
> +       Support for Xen detecting when it is running under Xen.
> +
> +       If unsure, say N.
> +
> +config PVH_GUEST
> +     def_bool n
> +     prompt "PVH Guest"
> +     depends on XEN_GUEST
> +     ---help---
> +       Support booting using the PVH ABI.
> +
> +       If unsure, say N.

The names of the options are ambiguous, yet I can't really think of
nice alternatives. Maybe XEN_AS_GUEST and XEN_AS_PVH_GUEST
or GUEST_OF_XEN and PHVH_GUEST_OF_XEN? Same goes for the
prompts and PVH_GUEST's help text.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel