[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 1/4] x86emul: Support GFNI insns

>>> On 04.01.18 at 10:20, <yang.zhong@xxxxxxxxx> wrote:
>   As for the test case for those insns, i am writing those related test 
> cases in tools/tests/x86_emulator.
>   How many test cases will you need ? One test case for one CPU 
> feature(vaes,gfni and vpclmulqdq)?

My rule of thumb is that I'd like to have tests for everything that isn't
fully matching "default" behavior of insn groups. That includes (but is
not limited to) unusual encoding or unusual memory operand sizes.
Therefore I think VAES and maybe also VPCLMULQDQ don't strictly
need individual tests (I still have on my todo list an entry to create a
blowfish-like test for AES and SHA, but that's independent of what
I'd like you to do), but the unusual .W1 encoding of some of the
GFNI insns certainly warrants one (whether that would be an
individual insn test or a blowfish-like one I'd leave to you). But
please realize that I'm writing this without having looked at the latest
version of the other two patches yet, so my opinion regarding the
former two may change once I get to that.

>   Another issue is would you please share your test guide?

I'm afraid I don't understand "test guide".


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.