Re: [Xen-devel] [PATCH 3/6] x86/shadow: ignore sh_pin() failure in one more case

[Tim Deegan <tim@xxxxxxx>]

At 08:06 -0700 on 12 Dec (1513065979), Jan Beulich wrote:
> Following what we've already done in the XSA-250 fix, convert another
> sh_pin() caller to no longer fail the higher level operation if pinning
> fails, as pinning is a performance optimization only in those places.
> 
> Suggested-by: Tim Deegan <tim@xxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Tim Deegan <tim@xxxxxxx>

> Would it be worth making sh_pin() return void, by adding a bool
> parameter which the other call site in sh_set_toplevel_shadow() could
> use to indicate a ref is avalable to be used (instead of aquiring a
> new one)? This would allow to drop another domain_crash().

No, let's keep the calling convention as it is, please.

Cheers

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel