Re: [Xen-devel] [PATCH] sched/null: skip vCPUs on the waitqueue that are blocked

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.12.17 at 15:16, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/common/sched_null.c
> +++ b/xen/common/sched_null.c
> @@ -781,6 +781,10 @@ static struct task_slice null_schedule(const struct 
> scheduler *ops,
>          {
>              list_for_each_entry( wvc, &prv->waitq, waitq_elem )
>              {
> +                if ( test_bit(_VPF_down, &wvc->vcpu->pause_flags) )
> +                    /* Skip vCPUs that are down. */
> +                    continue;

If such a custom check is indeed necessary here (looks to rather be
something generic scheduling code should be dealing with), why
would you take into consideration only this one VPF bit?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel