Re: [Xen-devel] [PATCH for-next 16/16] xen/arm: traps: Merge do_trap_instr_abort_guest and do_trap_data_abort_guest

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Stefano,

On 7 December 2017 at 22:43, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> On Thu, 23 Nov 2017, Julien Grall wrote:
>> @@ -2039,10 +1982,11 @@ static void do_trap_data_abort_guest(struct 
>> cpu_user_regs *regs,
>>      case FSC_FLT_PERM:
>>      {
>>          const struct npfec npfec = {
>> -            .read_access = !dabt.write,
>> -            .write_access = dabt.write,
>> +            .insn_fetch = !is_data,
>> +            .read_access = is_data && !hsr.dabt.write,
>> +            .write_access = is_data && !hsr.dabt.write,
>
> Shouldn't this be:
>
>     .write_access = is_data && hsr.dabt.write,
>

Hmmm, yes it should. I will resend the series minus the one you would merge.

Cheers,

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel