Re: [Xen-devel] [PATCH for-4.10 v2] x86/hvm: Fix altp2m_vcpu_enable_notify error handling

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi,

On 15/11/17 14:16, Andrew Cooper wrote:
> On 15/11/17 14:10, Jan Beulich wrote:
> > > > > On 15.11.17 at 14:47, <apop@xxxxxxxxxxxxxxx> wrote:
> > > The altp2m_vcpu_enable_notify subop handler might skip calling
> > > rcu_unlock_domain() after rcu_lock_current_domain().  Albeit since both
> > > rcu functions are no-ops when run on the current domain, this doesn't
> > > really have repercussions.
> > >
> > > The second change is adding a missing break that would have potentially
> > > enabled #VE for the current domain even if it had intended to enable it
> > > for another one (not a supported functionality).
> > Thanks, much better.
> >
> > > Signed-off-by: Adrian Pop <apop@xxxxxxxxxxxxxxx>
> > > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> FOAD, Requesting a release ack for this change.
Release-acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel