Re: [Xen-devel] [PATCH] osstest: remove unneeded rm in ts-freebsd-host-install

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH] osstest: remove unneeded rm in 
ts-freebsd-host-install"):
> The usage of `rm` here is wrong for two reasons:
> 
>  - It will fail if $sharedpath.tmp doesn't exist and report and error
>    (ie: -f should be used).
>  - It's not needed because dd will truncate $sharedpath.tmp.

I think it would be marginally better to use -f.  That way the
permissions and ownership of a previous abortive attempt are discarded
rather than kept.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel