[Xen-devel] [OSSTEST PATCH 1/2] resource_shared_mark_ready: Fix for non-`host' idents; fix $sharetype

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

$ho->{Ident} is completely wrong here.  That, ultimately, is going to
be restype.  But restype must be the fixed value `host'.  If this
function were called with a $ho whose Ident was `src_host' or
something, it would fail because hosts are all restype `host' in the
datanase, of course.

Also `$resource' here is the wrong variable name.  This is actually
the $sharetype (as is evident from jobdb_resource_shared_mark_ready
and what is now executive_resource_shared_mark_ready).

CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 Osstest/TestSupport.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 75f5a26..85ed57a 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -2859,10 +2859,10 @@ sub sha256file ($;$) {
 }
 
 sub resource_shared_mark_ready($$) {
-    my ($ho,$resource) = @_;
+    my ($ho,$sharetype) = @_;
 
-    $mjobdb->jobdb_resource_shared_mark_ready($ho->{Ident}, $ho->{Name},
-                                              $resource);
+    $mjobdb->jobdb_resource_shared_mark_ready('host', $ho->{Name},
+                                              $sharetype);
 }
 
 1;
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel