Re: [Xen-devel] [PATCH v6 07/20] osstest: introduce resource_shared_mark_ready

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v6 07/20] osstest: introduce 
resource_shared_mark_ready"):
> That allows marking a host as ready to be shared. Replace the current
> caller that open-codes it.
...
> -$mjobdb->jobdb_resource_shared_mark_ready
> -   ($ho->{Ident}, $ho->{Name}, "build-".$ho->{Suite}."-".$r{arch});
> +

Well.  On trying to build something on top of this, I notice that
$ho->{Ident} is completely wrong here.  That, ultimately, is going to
be restype.  But restype must be the fixed value `host'.

> +sub resource_shared_mark_ready($$) {
> +    my ($ho,$resource) = @_;
> +
> +    $mjobdb->jobdb_resource_shared_mark_ready($ho->{Ident}, $ho->{Name},
> +                                              $resource);
> +}

And this function `resource_shared_mark_ready' only marks hosts ready
- since it takea $ho.

I propose to send you a followup patch which renames your new
resource_shared_mark_ready to host_shared_mark_ready, and passes
'host' instead of $ho->{Ident}.  Alternatively I can wait for you to
do this, if that would be disruptive to you.

Also `$resource' here is the wrong variable name.  This is actually
the $sharetype (as is evident from jobdb_resource_shared_mark_ready
and what is now executive_resource_shared_mark_ready.  That is a bug
which is introduced in your patch.  Would you like to respin this as
you are about to rebase this onto what is about to become master,
anyway ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel