[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH for-4.10] scripts: add a script for build testing
Wei Liu writes ("Re: [PATCH for-4.10] scripts: add a script for build testing"): > On Mon, Oct 23, 2017 at 02:24:40AM -0600, Jan Beulich wrote: > > On 20.10.17 at 19:32, <wei.liu2@xxxxxxxxxx> wrote: > > > +git rebase $BASE $TIP -x "$CMD" > > > > Is this quoting on $CMD really going to work right no matter what > > the variable actually expands to? I.e. don't you either want to use > > "eval" or adjust script arguments such that you can use "$@" with > > its special quoting rules? Yes. Jan is completely right. > What sort of use cases you have in mind that involve complex quoting and > expansion? There is really no excuse at all, in a script like this, for not using `shift' to eat the main positional parameters, and then executing "$@", faithfully reproducing the incoming parameters. Of course there is a problem with getting this through git-rebase but as I have just pointed out, git-rev-list and git-checkout are much more suitable building blocks than git-rebase (which does a lot of undesirable stuff that has to be suppressed, etc.) Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |