[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device



On Fri, Oct 20, 2017 at 12:05:55PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume 
> device"):
> > See code comment for explanation.
> ...
> > +    # There might be stale entries in /etc/initramfs-tools/conf.d/resume
> > +    # which get stored in the initramfs. That introduces delay in guest 
> > booting
> > +    # which might cause tests to fail.
> 
> Why might there be such stale entries ?

The ramdisk is taken from the host, which contains that file. The resume
device is going to point to the swap partition in the host.

> 
> > +    # This is particularly prominent in systemd enabled releases when it 
> > tries
> > +    # to scan for the inexistent device(s) for a long time.
> 
> Why is this not a bug in systemd ?  If there are workarounds in
> osstest for Debian, I usually want a bug in the BTS, and a suite limit
> on the workaround so that we poke Debian again in 2 years time...
> 

It has always been like that since forever. It appears that stretch will
try a lot harder than jessie (which only tries once). Now thinking about
it I can't say for sure whether that's due to the new kernel, or systemd
or both.

> > +    # Override that in kernel command line with the correct swap partition.
> > +    $cfg =~ m/'phy:.+-swap,(xvda\d+),.*'/;
> > +    $extra .= " resume=/dev/$1";
> > +    logm("change resume device to $1");
> 
> Alternatively, if indeed this is necessary and not due to bugs,
> perhaps it should be done by xen-tools ?
> 

No, see the first paragraph. xen-tools can't be expected to modify the
ramdisk.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.