Re: [Xen-devel] [PATCH 00/12] ARM: VGIC/GIC separation cleanups

[Andre Przywara <andre.przywara@xxxxxxx>]

Hi,

On 19/10/17 13:48, Andre Przywara wrote:
> By the original VGIC design, Xen differentiates between the actual VGIC
> emulation on one hand and the GIC hardware accesses on the other.
> It seems there were some deviations from that scheme (over time?), so at
> the moment we end up happily accessing VGIC specific data structures
> like struct pending_irq and struct vgic_irq_rank from pure GIC files
> like gic.c or even irq.c (try: git grep -l struct\ pending_irq xen/arch/arm).
> But any future VGIC rework will depend on a clean separation, so this
> series tries to clean this up.
> It starts with some rather innocent patches, reaches its peak with the
> ugly patch 5/12 and the heavy 6/12, and calms down in the rest of the
> series again.
> After this series there are no more references to VGIC structures from
> GIC files, at least for non-ITS code. The ITS is a beast own its own
> (blame the author) and will be addressed later.
> 
> This is a first shot, any ideas on improvements are welcome.

Forgot to mention: This is of course not 4.10 material.

And I tested this is on Midway and Juno, with two guests migrating
interrupts like crazy over night:
           CPU0       CPU1
 18:    8892519    8892530     GIC-0  27 Level     arch_timer
 19:  193048966  192887534     GIC-0  31 Level     events
 20:        366          0   xen-dyn     Edge    -event     xenbus
 21:     180335     183325   xen-dyn     Edge    -event     hvc_console
 22:  112174867   81289537   xen-dyn     Edge    -event     blkif
 23:   80768079  111489990   xen-dyn     Edge    -event     blkif

But please give it a good shake on your setup to spot any regressions.

Cheers,
Andre.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel