Re: [Xen-devel] xenconsole: Define and use a macro INVALID_XEN_PFN instead of -1

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Wei,

On 10/18/2017 12:53 PM, Wei Liu wrote:
> On Wed, Oct 18, 2017 at 04:02:45AM -0600, Jan Beulich wrote:
> > > > > On 17.10.17 at 18:46, <bhupinder.thakur@xxxxxxxxxx> wrote:
> > > --- a/xen/include/public/xen.h
> > > +++ b/xen/include/public/xen.h
> > > @@ -37,6 +37,8 @@
> > >   #error "Unsupported architecture"
> > >   #endif
> > >   
> > > +#define INVALID_XEN_PFN (~(xen_pfn_t)0)
> > As said before, the uses of this which you introduce don't warrant
> > this addition to the public interface (which, if it was added, also
> > should start with XEN_). I'm not going to NAK such a (corrected)
> > addition to the public interface, but given the users I'm also not
> > going to ACK it (but perhaps another REST maintainer would).
> I agree with you here. We don't need this in public interface yet.
Couldn't this new define be used in place like xc_mem_access.c (they 
have a plain ~0UL for invalid GFN) or even LIBXL_INVALID_GFN?
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel