Re: [Xen-devel] [PATCH v2] libelf: allow having HYPERCALL_PAGE entry before VIRT_BASE in __xen_guest section.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.10.17 at 15:35, <gregory.herrero@xxxxxxxxxx> wrote:
> @@ -336,16 +337,22 @@ elf_errorstatus elf_xen_parse_guest_info(struct 
> elf_binary *elf,
>          if ( !strcmp(name, "ELF_PADDR_OFFSET") )
>              parms->elf_paddr_offset = strtoull(value, NULL, 0);
>          if ( !strcmp(name, "HYPERCALL_PAGE") )
> -            parms->virt_hypercall = (strtoull(value, NULL, 0) << 12) +
> -                parms->virt_base;
> +            parms->virt_hypercall = (strtoull(value, NULL, 0) << 12);

Please also drop the now pointless parentheses.

>          /* other */
>          if ( !strcmp(name, "FEATURES") )
>              if ( elf_xen_parse_features(value, parms->f_supported,
>                                          parms->f_required) )
> -                return -1;
> +            {
> +                ret = -1;
> +                break;
> +            }
>      }
> -    return 0;
> +    if ( (parms->virt_base != UNSET_ADDR) &&

Please add a blank line ahead of this addition.

With those taken care of
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel