Re: [Xen-devel] [PATCH v3 06/12] fuzz/x86_emulate: Take multiple test files for inputs

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/10/17 17:58, George Dunlap wrote:
> On 10/10/2017 05:56 PM, Andrew Cooper wrote:
>> On 10/10/17 17:20, George Dunlap wrote:
>>> @@ -65,12 +68,15 @@ int main(int argc, char **argv)
>>>  #ifdef __AFL_HAVE_MANUAL_CONTROL
>>>      __AFL_INIT();
>>>  
>>> -    while ( __AFL_LOOP(1000) )
>>> +    for( count = 0; __AFL_LOOP(1000); )
>>> +#else
>>> +    for( count = 0; count < max; count++ )
>>>  #endif
>>>      {
>>>          if ( fp != stdin ) /* If not using stdin, open the provided file. 
>>> */
>>>          {
>>> -            fp = fopen(argv[optind], "rb");
>>> +            printf("Opening file %s\n", argv[optind]);
>>> +            fp = fopen(argv[optind + count], "rb");
>> I presume the printf() wants adjusting to match the fopen() ?
> Oh!  I thought I'd fixed that.  Indeed it does.
>
> I can fix that on check-in, if we don't find anything bigger worth
> re-sending for.

I can't see anything else needing fixing.  Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel