Re: [Xen-devel] [PATCH v7 10/11] arm: vsmc: remove 64 bit mode check in PSCI handler

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi,

On 09/10/17 21:32, Stefano Stabellini wrote:
> On Fri, 6 Oct 2017, Julien Grall wrote:
> > Hi Volodymyr,
> >
> > On 04/10/17 22:00, Volodymyr Babchuk wrote:
> > > PSCI handling code had helper routine that checked calling convention.
> > > It does not needed anymore, because:
> > >
> > >    - Generic handler checks that 64 bit calls can be made only by
> > >      64 bit guests.
> > >
> > >    - SMCCC requires that 64-bit handler should support both 32 and 64 bit
> > >      calls even if they originate from 64 bit caller.
> > >
> > > This patch removes that extra check.
> > >
> > > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> > > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Sorry I just noticed this. This is odd to keep a reviewed-by from Stefano in a
> > patch that changed quite a bit since he gave it (patch #2).
> >
> > Usually reviewed-by means the person has reviewed the code and happy with it.
> > Technically, he didn't review the new changes and if not dropped, you should
> > have at least asked whether he is happy with it.
> >
> > Stefano are you happy if Volodymyr keeping your tag?
> No, the patch changed too much, I'll have to review it again. Drop it
> for now.
I will have a look. Only this patch and #4 are not acked and I would 
really like to see it merged in Xen 4.10 (code freeze tomorrow night).
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel