Re: [Xen-devel] [PATCH] Remove redundant code in branch MAP_PIRQ_TYPE_MSI

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Oct 09, 2017 at 06:00:15AM +0000, Zhenzhong Duan wrote:
> Same code is already in allocate_and_map_msi_pirq()
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Whit one nit below.

> ---
>  xen/arch/x86/physdev.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
> index 0eb4097..aa02d18 100644
> --- a/xen/arch/x86/physdev.c
> +++ b/xen/arch/x86/physdev.c
> @@ -122,8 +122,6 @@ int physdev_map_pirq(domid_t domid, int type, int *index, 
> int *pirq_p,
>          break;
>  
>      case MAP_PIRQ_TYPE_MSI:
> -        if ( !msi->table_base )
> -            msi->entry_nr = 1;
>          /* fallthrough */

Remove the fallthrough comment.

>      case MAP_PIRQ_TYPE_MULTI_MSI:
>          ret = allocate_and_map_msi_pirq(d, *index, pirq_p, type, msi);
> -- 
> 1.7.3
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel