Re: [Xen-devel] [PATCH 04/24] xentoolcore, _restrict_all: Introduce new library and implementation

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 10/04/2017 04:57 PM, Ian Jackson wrote:
> diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
> new file mode 100644
> index 0000000..f86f839
> --- /dev/null
> +++ b/tools/libs/toolcore/Makefile
> @@ -0,0 +1,101 @@
> +XEN_ROOT = $(CURDIR)/../../..
> +include $(XEN_ROOT)/tools/Rules.mk
> +
> +MAJOR  = 1
> +MINOR  = 0
> +SHLIB_LDFLAGS += -Wl,--version-script=libxentoolcore.map
> +
> +CFLAGS += -Werror -Wmissing-prototypes
> +CFLAGS += -I./include
> +
> +SRCS-y += handlereg.c
> +
> +LIB_OBJS := $(patsubst %.c,%.o,$(SRCS-y))
> +PIC_OBJS := $(patsubst %.c,%.opic,$(SRCS-y))
> +
> +LIB := libxentoolcore.a
> +ifneq ($(nosharedlibs),y)
> +LIB += libxentoolcore.so
> +endif
> +
> +PKG_CONFIG := xentoolcore.pc
> +PKG_CONFIG_VERSION := $(MAJOR).$(MINOR)
> +
> +ifneq ($(CONFIG_LIBXC_MINIOS),y)
> +PKG_CONFIG_INST := $(PKG_CONFIG)
> +$(PKG_CONFIG_INST): PKG_CONFIG_PREFIX = $(prefix)
> +$(PKG_CONFIG_INST): PKG_CONFIG_INCDIR = $(includedir)
> +$(PKG_CONFIG_INST): PKG_CONFIG_LIBDIR = $(libdir)
> +endif
> +
> +PKG_CONFIG_LOCAL := $(foreach pc,$(PKG_CONFIG),$(PKG_CONFIG_DIR)/$(pc))
> +
> +$(PKG_CONFIG_LOCAL): PKG_CONFIG_PREFIX = $(XEN_ROOT)
> +$(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR = $(XEN_LIBXENTOOLCORE)/include
> +$(PKG_CONFIG_LOCAL): PKG_CONFIG_LIBDIR = $(CURDIR)
> +
> +AUTOINCS=include/_xentoolcore_list.h
> +
> +.PHONY: all
> +all: build
> +
> +.PHONY: build
> +build:
> +       $(MAKE) libs
> +
> +.PHONY: libs
> +libs: headers.chk $(LIB) $(PKG_CONFIG_INST) $(PKG_CONFIG_LOCAL)
> +
> +%.o: $(AUTOINCS)
> +%.opic: $(AUTOINCS)
> +
Adding extra prerequisites to pattern rules like that doesn't seem to 
work. I get occasional build failures from a clean tree:
In file included from handlereg.c:23:0:
./include/xentoolcore_internal.h:30:31: fatal error: 
_xentoolcore_list.h: No such file or directory
 #include "_xentoolcore_list.h"

Replacing these pattern rules with hardcoded rules fixes the problem 
(although presumably there's a better way):
handlereg.o: $(AUTOINCS)
handlereg.opic: $(AUTOINCS)

--
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel