Re: [Xen-devel] [PATCH] xen, tools: console.h shouldn't require string.h by default

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 06, 2017 at 06:39:22AM -0600, Jan Beulich wrote:
> >>> On 06.10.17 at 13:48, <wei.liu2@xxxxxxxxxx> wrote:
> > @@ -40,7 +38,9 @@ struct xencons_interface {
> >      XENCONS_RING_IDX out_cons, out_prod;
> >  };
> >  
> > -#if defined(__GNUC__) && !defined(__STRICT_ANSI__)
> > +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) && \
> > +    defined(XEN_WANT_FLEX_CONSOLE_RING)
> > +#include "ring.h"
> >  DEFINE_XEN_FLEX_RING(xencons);
> >  #endif
> 
> Wouldn't it be reasonable to drop the GNU and ANSI checks?
> Someone not using a suitable compiler simply shouldn't define
> the macro.

That would be fine by me.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel