Re: [Xen-devel] [PATCH v4 01/11] livepatch: Expand check for safe_for_reapply if livepatch has only .rodata.

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 10/05/2017 02:51 PM, Konrad Rzeszutek Wilk wrote:
> On Thu, Oct 05, 2017 at 02:47:30PM +0100, Ross Lagerwall wrote:
> > On 09/20/2017 11:31 PM, Konrad Rzeszutek Wilk wrote:
> > > If the livepatch has only .rodata sections then it is OK to also
> > > apply/revert/apply the livepatch without having to worry about the
> > > unforseen consequences.
> > >
> > > See commit 98b728a7b235c67e210f67f789db5d9eb38ca00c
> > > "livepatch: Disallow applying after an revert" for details.
> > >
> > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > > ---
> > > Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> > The patch looks OK, but what is the use case for a live patch with only
> > .rodata?
> A NOP one. This hasn't been an issue in the past, but further patches
> change the .livepatch_funcs from RW to RO (to be in line with what
> livepatch-build-tools.git do) - and then the xen_nop testcase does not
> work anymore.

Thanks, that makes sense.

Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel