Re: [Xen-devel] [PATCH 2/3] x86/vmx: Don't self-recurse in vmx_update_guest_cr()

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Sep 29, 2017 at 06:31:02PM +0000, Andrew Cooper wrote:
> An update to CR4 following a CR0 update can be done easily by falling
> through into the CR4 case.  This avoids unnecessary passes through
> vmx_vmcs_{enter,exit}() and unnecessary stack usage (as the compiler
> cannot optimise this use to a tailcall).
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

LGTM:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Maybe you should add to the commit message that this is not a
functional change?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel